Skip to content

Feature/update runtime #71

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Aug 5, 2022

Conversation

duncangrant
Copy link
Contributor

This PR updates #51 - which has merge conflicts

Description of changes: Update to Node.js 14.x runtime

Related to issue: aws-cloudformation/cloudformation-cli#746

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov
Copy link

codecov bot commented Aug 5, 2022

Codecov Report

Merging #71 (1473316) into master (a71767d) will increase coverage by 0.15%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master      #71      +/-   ##
==========================================
+ Coverage   98.38%   98.53%   +0.15%     
==========================================
  Files          13       13              
  Lines        1237     1232       -5     
  Branches      217      209       -8     
==========================================
- Hits         1217     1214       -3     
+ Misses         19       17       -2     
  Partials        1        1              
Flag Coverage Δ
unittests 98.53% <100.00%> (+0.15%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
python/rpdk/typescript/codegen.py 98.65% <100.00%> (ø)
src/resource.ts 97.26% <0.00%> (+0.71%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@ammokhov ammokhov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, thank you for the contribution

@ammokhov ammokhov merged commit e009036 into aws-cloudformation:master Aug 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants